It is well established that magmatism is trans-crustal, with melt storage and processing occurring over a range of depths. Development of this conceptual model was based on observations of the products of magmatism at spreading ridges, including Iceland. Petrological barometry and tracking of the solidification process has been used to show that the Icelandic crust is built by crystallization over a range of depths. The available petrological evidence indicates that most of the active rift zones are not underlain by extensive and pervasive crystal mush. Instead, the microanalytical observations from Iceland are consistent with a model where magmatic processing in the lower crust occurs in sills of decimetric vertical thickness. This stacked sills mode of crustal accretion corresponds to that proposed for the oceanic crust on the basis of ophiolite studies. A key feature of these models is that the country rock for the sills is hot but subsolidus. This condition can be met if the porosity in thin crystal mushes at the margins of the sills is occluded by primitive phases, a contention that is consistent with observations from cumulate nodules in Icelandic basalts. The conditions required for the stabilization of trans-crustal mushes may not be present in magmatic systems at spreading ridges. This article is part of the Theo Murphy meeting issue 'Magma reservoir architecture and dynamics'.